Skip to content

marvin: specify the charset as utf8mb4 in dbConnection.py#13437

Draft
weizhouapache wants to merge 1 commit into
apache:4.22from
weizhouapache:4.22-marvin-db-charset-utf8mb4
Draft

marvin: specify the charset as utf8mb4 in dbConnection.py#13437
weizhouapache wants to merge 1 commit into
apache:4.22from
weizhouapache:4.22-marvin-db-charset-utf8mb4

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes the issues like below in smoke tests

Traceback (most recent call last):
  File "/marvin/tests/smoke/test_outofbandmanagement.py", line 93, in tearDown
    raise Exception("Warning: Exception during cleanup : %s" % e)
Exception: Warning: Exception during cleanup : Character set 'utf8' unsupported

"utf8" is unsupported since mysql-connector-python 8.0.31

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg Bot added component:marvin Python Warning... Python code Ahead! labels Jun 17, 2026
@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.67%. Comparing base (8e933b7) to head (3840708).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #13437      +/-   ##
============================================
- Coverage     17.67%   17.67%   -0.01%     
+ Complexity    15792    15791       -1     
============================================
  Files          5922     5922              
  Lines        533167   533167              
  Branches      65210    65210              
============================================
- Hits          94246    94243       -3     
- Misses       428276   428278       +2     
- Partials      10645    10646       +1     
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18286

@DaanHoogland DaanHoogland added this to the 4.22.2 milestone Jun 18, 2026

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:marvin Python Warning... Python code Ahead!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants